[
https://issues.apache.org/jira/browse/PHOENIX-5303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849346#comment-16849346
]
Lars Hofhansl commented on PHOENIX-5303:
----------------------------------------
Found it.
In HBase 1.4:
{code:java}
@Override
public ReturnCode filterKeyValue(Cell v) {
int qualifierLength = v.getQualifierLength();
if (qualifierLength > 0) {
if (doCompare(this.compareOp, this.comparator, v.getQualifierArray(),
v.getQualifierOffset(), qualifierLength)) {
return ReturnCode.SKIP;
}
}
return ReturnCode.INCLUDE;
}
{code}
In HBase 1.5:
{code:java}
@Override
public ReturnCode filterKeyValue(Cell v) {
if (doCompare(this.compareOp, this.comparator, v.getQualifierArray(),
v.getQualifierOffset(), v.getQualifierLength())) {
return ReturnCode.SKIP;
}
return ReturnCode.INCLUDE;
}
{code}
Phoenix in this case passes down a family delete marker and expects that the
empty qualifier length will cause an INCLUDE. You could argue that Phoenix is
weird here, but the difference is a very subtle change in HBase.
> HBase 1.5 specific test failures
> --------------------------------
>
> Key: PHOENIX-5303
> URL: https://issues.apache.org/jira/browse/PHOENIX-5303
> Project: Phoenix
> Issue Type: Test
> Affects Versions: 4.15.0
> Reporter: Lars Hofhansl
> Priority: Critical
> Fix For: 4.15.0
>
>
> This must have started very recently, but it's already past the history of
> the test runs.
> Or perhaps it never works in 4.x-HBase-1.5
> [~apurtell], in case you have any ideas.
> {code:java}
> [INFO] Running
> org.apache.phoenix.hbase.index.covered.TestCoveredColumnIndexCodec
> [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.403
> s <<< FAILURE! - in
> org.apache.phoenix.hbase.index.covered.TestCoveredColumnIndexCodec
> [ERROR]
> testGeneratedIndexUpdates(org.apache.phoenix.hbase.index.covered.TestCoveredColumnIndexCodec)
> Time elapsed: 0.16 s <<< FAILURE!
> java.lang.AssertionError: Had some index updates, though it should have been
> covered by the delete
> at
> org.apache.phoenix.hbase.index.covered.TestCoveredColumnIndexCodec.ensureNoUpdatesWhenCoveredByDelete(TestCoveredColumnIndexCodec.java:242)
> at
> org.apache.phoenix.hbase.index.covered.TestCoveredColumnIndexCodec.testGeneratedIndexUpdates(TestCoveredColumnIndexCodec.java:220)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
