[
https://issues.apache.org/jira/browse/PHOENIX-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850324#comment-16850324
]
Hadoop QA commented on PHOENIX-5305:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12970087/PHOENIX-5305-4.x-HBase-1.4.patch
against 4.x-HBase-1.4 branch at commit
d43bc67dea852b3c9d7c419680d3a1edf8d870c7.
ATTACHMENT ID: 12970087
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 120
new or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 2 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ private static void testExpression(LiteralExpression array,
LiteralExpression element, PhoenixArray expected)
+ PhoenixArray result = (PhoenixArray)
arrayAppendFunction.getDataType().toObject(ptr,
expressions.get(0).getSortOrder(), array.getMaxLength(), array.getScale());
+ private static void test(PhoenixArray array, Object element, PDataType
arrayDataType, Integer arrMaxLen, Integer arrScale, PDataType elementDataType,
Integer elemMaxLen, Integer elemScale, PhoenixArray expected, SortOrder
arraySortOrder, SortOrder elementSortOrder) throws SQLException {
+ arrayLiteral = LiteralExpression.newConstant(array, arrayDataType,
arrMaxLen, arrScale, arraySortOrder, Determinism.ALWAYS);
+ elementLiteral = LiteralExpression.newConstant(element,
elementDataType, elemMaxLen, elemScale, elementSortOrder, Determinism.ALWAYS);
+ test(arr, element, PDataType.fromTypeId(baseType.getSqlType() +
PDataType.ARRAY_TYPE_BASE), null, null, baseType, null, null, expected,
SortOrder.ASC, SortOrder.ASC);
+ test(arr, element, PDataType.fromTypeId(baseType.getSqlType() +
PDataType.ARRAY_TYPE_BASE), null, null, baseType, null, null, expected,
SortOrder.ASC, SortOrder.ASC);
+ test(arr, element, PDataType.fromTypeId(baseType.getSqlType() +
PDataType.ARRAY_TYPE_BASE), null, null, baseType, null, null, expected,
SortOrder.ASC, SortOrder.ASC);
+ test(arr, element, PDataType.fromTypeId(baseType.getSqlType() +
PDataType.ARRAY_TYPE_BASE), null, null, baseType, null, null, expected,
SortOrder.ASC, SortOrder.ASC);
+ Object[] o2 = new Object[]{new Float(2.3), new Float(7.9), new
Float(-9.6), new Float(2.3), new Float(8.9)};
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinMoreIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexRebuildTaskIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.PermissionsCacheIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2608//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2608//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2608//console
This message is automatically generated.
> Move expression function tests to the right folder
> --------------------------------------------------
>
> Key: PHOENIX-5305
> URL: https://issues.apache.org/jira/browse/PHOENIX-5305
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Xinyi Yan
> Assignee: Xinyi Yan
> Priority: Trivial
> Attachments: PHOENIX-5305-4.x-HBase-1.4.patch
>
>
> As [~chenglei] discovered on the other Jira, many phoenix expression function
> tests are not under the right folder. Put function tests under the package
> `{{org.apache.phoenix.expression.function}} ` instead of
> `{{org.apache.phoenix.expression}}` for better code quality.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
