gokceni commented on a change in pull request #514: PHOENIX-5261: Implement
ALTER TABLE/VIEW ADD COLUMN CASCADE
URL: https://github.com/apache/phoenix/pull/514#discussion_r290962292
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##########
@@ -3528,14 +3530,25 @@ private void mutateStringProperty(String tenantId,
String schemaName, String tab
public MutationState addColumn(AddColumnStatement statement) throws
SQLException {
PTable table = FromCompiler.getResolver(statement,
connection).getTables().get(0).getTable();
- return addColumn(table, statement.getColumnDefs(),
statement.getProps(), statement.ifNotExists(), false, statement.getTable(),
statement.getTableType());
+ return addColumn(table, statement.getColumnDefs(),
statement.getProps(), statement.ifNotExists(), false, statement.getTable(),
statement.getTableType(), statement.isCascade(), statement.getIndexes());
}
public MutationState addColumn(PTable table, List<ColumnDef>
origColumnDefs,
ListMultimap<String, Pair<String, Object>> stmtProperties, boolean
ifNotExists,
- boolean removeTableProps, NamedTableNode namedTableNode,
PTableType tableType)
+ boolean removeTableProps, NamedTableNode namedTableNode,
PTableType tableType, boolean cascade, List<NamedNode> indexes)
throws SQLException {
connection.rollback();
+ List<PTable> indexesPTable =
Lists.newArrayListWithExpectedSize(indexes != null ?
+ indexes.size() : table.getIndexes().size());
+ // if cascade keyword is passed and indexes are provided either
implicitly or explicitly
+ if (cascade && (indexes == null || indexes.size()>0)) {
+ if (indexes == null) {
+ indexesPTable = table.getIndexes();
+ } else {
+ indexesPTable = table.getIndexes(indexes);
+ }
+ }
+ int numIndexes = indexesPTable == null ? 0 : indexesPTable.size();
Review comment:
nit: this doesn't seem necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
