dbwong commented on a change in pull request #515: PHOENIX-5318 Slots passed to
SkipScan filter is incorrect for desc pr…
URL: https://github.com/apache/phoenix/pull/515#discussion_r291705600
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/query/KeyRange.java
##########
@@ -108,6 +109,34 @@ public KeyRange apply(byte[] input) {
}
};
Review comment:
Ok I looked in more detail and I agree. While this may not be the ideal fix
I'm still a bit worried though on if we have a region boundary there could
still be issues as we may not intersect properly as the data on disk will
contain the FF. I don't think this should hurt though maybe we should add this
note to https://issues.apache.org/jira/browse/PHOENIX-4306 as something we want
to test in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
