priyankporwal commented on a change in pull request #514: PHOENIX-5261:
Implement ALTER TABLE/VIEW ADD COLUMN CASCADE
URL: https://github.com/apache/phoenix/pull/514#discussion_r291884611
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##########
@@ -3707,6 +3738,13 @@ public MutationState addColumn(PTable table,
List<ColumnDef> origColumnDefs,
}
colFamiliesForPColumnsToBeAdded.add(column.getFamilyName() == null ? null :
column.getFamilyName().getString());
addColumnMutation(schemaName, tableName, column,
colUpsert, null, pkName, keySeq, table.getBucketNum() != null);
+ // add new columns for given indexes one by one
+ if (cascade) {
+ for (PTable index: indexesPTable) {
+ logger.info("Adding column to
"+index.getTableName().toString());
Review comment:
Please add the column name here to make this log-line really useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
