priyankporwal commented on a change in pull request #517: PHOENIX-5211
Consistent Immutable Global Indexes for Non-Transactiona…
URL: https://github.com/apache/phoenix/pull/517#discussion_r293019982
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java
##########
@@ -294,13 +295,32 @@ private static boolean isEmptyKeyValue(PTable table,
ColumnReference ref) {
.getLength()) == 0);
}
+
+ public static boolean isGlobalIndexCheckerEnabled(PhoenixConnection
connection, PName index) {
+ TableDescriptor desc = null;
+ try {
+ desc =
connection.getQueryServices().getTableDescriptor(index.getBytes());
+ } catch (SQLException ex) {
+ //logger.warn("Error during getTableDescriptor ", ex);
Review comment:
Can we throw this exception instead of silently ignoring it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
