gokceni commented on a change in pull request #517: PHOENIX-5211 Consistent Immutable Global Indexes for Non-Transactiona… URL: https://github.com/apache/phoenix/pull/517#discussion_r293562760
########## File path: phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ########## @@ -24,14 +24,19 @@ import static org.apache.phoenix.monitoring.GlobalClientMetrics.GLOBAL_MUTATION_COMMIT_TIME; import static org.apache.phoenix.query.QueryServices.WILDCARD_QUERY_DYNAMIC_COLS_ATTRIB; import static org.apache.phoenix.query.QueryServicesOptions.DEFAULT_WILDCARD_QUERY_DYNAMIC_COLS_ATTRIB; +import static org.apache.phoenix.schema.types.PDataType.FALSE_BYTES; +import static org.apache.phoenix.schema.types.PDataType.TRUE_BYTES; Review comment: There is a MutationStateIT class, it might count as unit/it tests. My changes are mostly refactors. There was a huge send() method, I refactored and moved some part of send code into sendMutations function. This is the place where client creates and sends mutations for index and data table. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
