kadirozde commented on a change in pull request #517: PHOENIX-5211 Consistent
Immutable Global Indexes for Non-Transactiona…
URL: https://github.com/apache/phoenix/pull/517#discussion_r294605204
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java
##########
@@ -896,21 +906,31 @@ private void send(Iterator<TableRef> tableRefIterator)
throws SQLException {
continue;
}
// Validate as we go if transactional since we can undo if a
problem occurs (which is unlikely)
- long serverTimestamp = serverTimeStamps == null ?
validateAndGetServerTimestamp(tableRef,
- multiRowMutationState) : serverTimeStamps[i++];
+ long
+ serverTimestamp =
+ serverTimeStamps == null ?
+ validateAndGetServerTimestamp(tableRef,
multiRowMutationState) :
+ serverTimeStamps[i++];
Long scn = connection.getSCN();
long mutationTimestamp = scn == null ?
HConstants.LATEST_TIMESTAMP : scn;
final PTable table = tableRef.getTable();
- Iterator<Pair<PName, List<Mutation>>> mutationsIterator =
addRowMutations(tableRef,
- multiRowMutationState, mutationTimestamp,
serverTimestamp, false, sendAll);
+ Iterator<Pair<PName, List<Mutation>>>
+ mutationsIterator =
+ addRowMutations(tableRef, multiRowMutationState,
mutationTimestamp,
+ serverTimestamp, false, sendAll);
// build map from physical table to mutation list
boolean isDataTable = true;
while (mutationsIterator.hasNext()) {
Pair<PName, List<Mutation>> pair =
mutationsIterator.next();
PName hTableName = pair.getFirst();
List<Mutation> mutationList = pair.getSecond();
+ if (clonedDataMutations.size() == 0) {
Review comment:
clonedDataMutations are not used anymore. We can remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
