[
https://issues.apache.org/jira/browse/PHOENIX-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867142#comment-16867142
]
Hadoop QA commented on PHOENIX-5228:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12972138/PHOENIX-5228-FIX-master.patch
against master branch at commit 56e0f0381fe30005f3cdd1718f99f3205e56d99e.
ATTACHMENT ID: 12972138
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 2 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ LOGGER.info("Starting to partially build
indexes:" + indexesToPartiallyRebuild
+ LOGGER.info("Rebuild completed for all
inactive/disabled indexes in data table:"
+ LOGGER.info(" no. of datatable rows read in
rebuilding process is " + rowCount);
+ LOGGER.info("Making Index:" +
indexPTable.getTableName() + " active after rebuilding");
+ LOGGER.error("Unable to rebuild " +
dataPTable + " index " + indexTableFullName, e);
+ LOGGER.error("Unable to rebuild " + dataPTable + "
indexes " + indexesToPartiallyRebuild, e);
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2686//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2686//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2686//console
This message is automatically generated.
> use slf4j for logging in phoenix project
> ----------------------------------------
>
> Key: PHOENIX-5228
> URL: https://issues.apache.org/jira/browse/PHOENIX-5228
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.14.1, 5.1.0
> Reporter: Mihir Monani
> Assignee: Xinyi Yan
> Priority: Trivial
> Labels: SFDC
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5228-4.x-HBase-1.3.patch,
> PHOENIX-5228-4.x-HBase-1.4.patch, PHOENIX-5228-4.x-HBase-1.5.patch,
> PHOENIX-5228-FIX-4.x-HBase-1.3.patch, PHOENIX-5228-FIX-4.x-HBase-1.4.patch,
> PHOENIX-5228-FIX-4.x-HBase-1.4.patch, PHOENIX-5228-FIX-4.x-HBase-1.5.patch,
> PHOENIX-5228-FIX-master.patch, PHOENIX-5228.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> It would be good to use slf4j for logging in phoenix project. Here is list of
> files where doesn't use slf4j.
> phoenix-core :-
> {noformat}
> WALRecoveryRegionPostOpenIT.java
> WALReplayWithIndexWritesAndCompressedWALIT.java
> BasePermissionsIT.java
> ChangePermissionsIT.java
> IndexRebuildIncrementDisableCountIT.java
> InvalidIndexStateClientSideIT.java
> MutableIndexReplicationIT.java
> FailForUnsupportedHBaseVersionsIT.java
> SecureUserConnectionsIT.java
> PhoenixMetricsIT.java
> BaseTracingTestIT.java
> PhoenixTracingEndToEndIT.java
> PhoenixRpcSchedulerFactory.java
> IndexHalfStoreFileReaderGenerator.java
> BinaryCompatibleBaseDecoder.java
> ServerCacheClient.java
> CallRunner.java
> MetaDataRegionObserver.java
> PhoenixAccessController.java
> ScanRegionObserver.java
> TaskRegionObserver.java
> DropChildViewsTask.java
> IndexRebuildTask.java
> BaseQueryPlan.java
> HashJoinPlan.java
> CollationKeyFunction.java
> Indexer.java
> LockManager.java
> BaseIndexBuilder.java
> IndexBuildManager.java
> NonTxIndexBuilder.java
> IndexMemStore.java
> BaseTaskRunner.java
> QuickFailingTaskRunner.java
> TaskBatch.java
> ThreadPoolBuilder.java
> ThreadPoolManager.java
> IndexManagementUtil.java
> IndexWriter.java
> IndexWriterUtils.java
> KillServerOnFailurePolicy.java
> ParallelWriterIndexCommitter.java
> RecoveryIndexWriter.java
> TrackingParallelWriterIndexCommitter.java
> PhoenixIndexFailurePolicy.java
> PhoenixTransactionalIndexer.java
> SnapshotScanner.java
> PhoenixEmbeddedDriver.java
> PhoenixResultSet.java
> QueryLogger.java
> QueryLoggerDisruptor.java
> TableLogWriter.java
> PhoenixInputFormat.java
> PhoenixOutputFormat.java
> PhoenixRecordReader.java
> PhoenixRecordWriter.java
> PhoenixServerBuildIndexInputFormat.java
> PhoenixMRJobSubmitter.java
> PhoenixConfigurationUtil.java
> Metrics.java
> DefaultStatisticsCollector.java
> StatisticsScanner.java
> PhoenixMetricsSink.java
> TraceReader.java
> TraceSpanReceiver.java
> TraceWriter.java
> Tracing.java
> EquiDepthStreamHistogram.java
> PhoenixMRJobUtil.java
> QueryUtil.java
> ServerUtil.java
> ZKBasedMasterElectionUtil.java
> IndexTestingUtils.java
> StubAbortable.java
> TestIndexWriter.java
> TestParalleIndexWriter.java
> TestParalleWriterIndexCommitter.java
> TestWALRecoveryCaching.java
> LoggingSink.java
> ParameterizedPhoenixCanaryToolIT.java
> CoprocessorHConnectionTableFactoryTest.java
> TestUtil.java{noformat}
> phoenix-tracing-webapp :-
> {noformat}
> org/apache/phoenix/tracingwebapp/http/Main.java
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
