gjacoby126 commented on a change in pull request #520: PHOENIX-5333: A tool to
upgrade existing tables/indexes to use self-c…
URL: https://github.com/apache/phoenix/pull/520#discussion_r295516979
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexUpgradeToolIT.java
##########
@@ -0,0 +1,506 @@
+package org.apache.phoenix.end2end;
+
+import com.google.common.collect.Maps;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.TableNotFoundException;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.phoenix.hbase.index.IndexRegionObserver;
+import org.apache.phoenix.hbase.index.Indexer;
+import org.apache.phoenix.index.GlobalIndexChecker;
+import org.apache.phoenix.jdbc.PhoenixConnection;
+import org.apache.phoenix.mapreduce.index.IndexUpgradeTool;
+import org.apache.phoenix.query.BaseTest;
+import org.apache.phoenix.query.ConnectionQueryServices;
+import org.apache.phoenix.query.QueryServices;
+import org.apache.phoenix.query.QueryServicesOptions;
+import org.apache.phoenix.util.PropertiesUtil;
+import org.apache.phoenix.util.ReadOnlyProps;
+import org.apache.phoenix.util.SchemaUtil;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized.Parameters;
+import org.junit.runners.Parameterized;
+
+
+import java.io.BufferedWriter;
+import java.io.File;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Map;
+import java.util.Properties;
+import java.util.UUID;
+
+@RunWith(Parameterized.class)
+@Category(NeedsOwnMiniClusterTest.class)
+public class IndexUpgradeToolIT extends BaseTest {
+
+ private final boolean mutable;
+ private final boolean upgrade;
+ private StringBuilder optionsBuilder;
+ private String tableDDLOptions;
+
+ private static Map<String, String> serverProps =
Maps.newHashMapWithExpectedSize(1), clientProps =
Maps.newHashMapWithExpectedSize(1);
+
+ private String [] indexesList = {"TEST.INDEX1", "TEST.INDEX2",
"TEST1.INDEX3","TEST1.INDEX2","TEST1.INDEX1","TEST.INDEX3"};
+ private String [] tableList = {"TEST.MOCK1","TEST1.MOCK2","TEST.MOCK3"};
+
+ private String inputList =
"TEST.MOCK1:INDEX1,INDEX2;TEST1.MOCK2:INDEX3,INDEX2,INDEX1;TEST.MOCK3:INDEX3";
+
+
+ @Before
+ public void setup () throws Exception {
+ optionsBuilder = new StringBuilder();
+
+ if (upgrade) {
+ if
((Boolean.TRUE.toString()).equals(clientProps.get(QueryServices.INDEX_REGION_OBSERVER_ENABLED_ATTRIB)))
{
+ tearDownMiniClusterAsync(1);
+ }
+
clientProps.put(QueryServices.INDEX_REGION_OBSERVER_ENABLED_ATTRIB,
Boolean.FALSE.toString());
+ } else {
+ if
((Boolean.FALSE.toString()).equals(clientProps.get(QueryServices.INDEX_REGION_OBSERVER_ENABLED_ATTRIB)))
{
+ tearDownMiniClusterAsync(1);
+ }
+
clientProps.put(QueryServices.INDEX_REGION_OBSERVER_ENABLED_ATTRIB,
Boolean.TRUE.toString());
+ }
+ if (!mutable) {
+ optionsBuilder.append(" IMMUTABLE_ROWS=true");
+ }
+ setUpTestDriver(new ReadOnlyProps(serverProps.entrySet().iterator()),
+ new ReadOnlyProps(clientProps.entrySet().iterator()));
+ tableDDLOptions = optionsBuilder.toString();
+ try (Connection conn = DriverManager.getConnection(getUrl(), new
Properties())) {
+ conn.setAutoCommit(true);
+ prepareSetup(conn);
+ }
+
+ }
+
+
+ private void prepareSetup(Connection conn) throws SQLException {
+ //inputList is "TEST.MOCK1: INDEX1, INDEX2; TEST1.MOCK2: INDEX3,
INDEX2, INDEX1; TEST.MOCK3: INDEX3";
+ conn.createStatement().execute("CREATE TABLE TEST.MOCK1 (id bigint NOT
NULL PRIMARY KEY, a.name varchar, sal bigint, address
varchar)"+tableDDLOptions);
+ conn.createStatement().execute("CREATE TABLE TEST1.MOCK2 (id bigint
NOT NULL PRIMARY KEY, name varchar, city varchar, phone
bigint)"+tableDDLOptions);
+ conn.createStatement().execute("CREATE TABLE TEST.MOCK3 (id bigint NOT
NULL PRIMARY KEY, name varchar, age bigint)"+tableDDLOptions);
+
+ conn.createStatement().execute("CREATE INDEX INDEX1 ON TEST.MOCK1
(sal, a.name)");
+ conn.createStatement().execute("CREATE INDEX INDEX2 ON TEST.MOCK1
(a.name)");
+ conn.createStatement().execute("CREATE INDEX INDEX1 ON TEST1.MOCK2
(city)");
+ conn.createStatement().execute("CREATE INDEX INDEX2 ON TEST1.MOCK2
(phone)");
+ conn.createStatement().execute("CREATE INDEX INDEX3 ON TEST1.MOCK2
(name)");
+ conn.createStatement().execute("CREATE INDEX INDEX3 ON TEST.MOCK3
(age, name)");
+ }
+
+ @Parameters(name ="IndexUpgradeToolIT_mutable={0},upgrade={1}")
+ public static Collection<Object[]> data() {
+ return Arrays.asList(new Object[][] {
+ {false, true},
+ {true, true},
+ {false, false},
+ {true, false}
+ });
+ }
+
+ public IndexUpgradeToolIT (boolean mutable, boolean upgrade) {
+ this.mutable = mutable;
+ this.upgrade = upgrade;
+ }
+
+ @Test
+ public void testToolWithOneTableOneIndex() throws SQLException,
IOException {
+ String schemaName = generateUniqueName();
+ String dataTableName = generateUniqueName();
+ String dataTableFullName = SchemaUtil.getTableName(schemaName,
dataTableName);
+ String indexTableName = generateUniqueName();
+ try (Connection conn = DriverManager.getConnection(getUrl(), new
Properties())) {
+ conn.setAutoCommit(true);
+ ConnectionQueryServices queryServices =
conn.unwrap(PhoenixConnection.class).getQueryServices();
+ Admin admin = queryServices.getAdmin();
+ conn.createStatement().execute("CREATE TABLE " + dataTableFullName
+ " (id bigint NOT NULL PRIMARY KEY, name varchar)" + tableDDLOptions);
+ conn.createStatement().execute("CREATE INDEX " + indexTableName +
" ON " + dataTableFullName + " (name)");
+
+ ArrayList<String> args = new ArrayList<>();
+ args.add("-o");
+ if (upgrade) {
+ args.add("upgrade");
+ if (mutable) {
+
Assert.assertTrue(admin.getDescriptor(TableName.valueOf(dataTableFullName)).hasCoprocessor(Indexer.class.getName()));
+
Assert.assertFalse(admin.getDescriptor(TableName.valueOf(dataTableFullName)).hasCoprocessor(IndexRegionObserver.class.getName()));
+ }
+
Assert.assertFalse(admin.getDescriptor(TableName.valueOf(schemaName + "." +
indexTableName)).hasCoprocessor(GlobalIndexChecker.class.getName()));
+ } else {
+ args.add("rollback");
+ if (mutable) {
+
Assert.assertTrue(admin.getDescriptor(TableName.valueOf(dataTableFullName)).hasCoprocessor(IndexRegionObserver.class.getName()));
+
Assert.assertFalse(admin.getDescriptor(TableName.valueOf(dataTableFullName)).hasCoprocessor(Indexer.class.getName()));
+ }
+
Assert.assertTrue(admin.getDescriptor(TableName.valueOf(schemaName + "." +
indexTableName)).hasCoprocessor(GlobalIndexChecker.class.getName()));
+ }
+ args.add("-tb");
+ args.add(dataTableFullName + ":" + indexTableName);
+ args.add("-c");
+ args.add(conn.unwrap(PhoenixConnection.class).getURL());
+ IndexUpgradeTool.main(args.toArray(new String[args.size()]));
+ if (upgrade) {
+ if (mutable) {
+
Assert.assertTrue(admin.getDescriptor(TableName.valueOf(dataTableFullName)).hasCoprocessor(IndexRegionObserver.class.getName()));
+
Assert.assertFalse(admin.getDescriptor(TableName.valueOf(dataTableFullName)).hasCoprocessor(Indexer.class.getName()));
+ }
+
Assert.assertTrue(admin.getDescriptor(TableName.valueOf(schemaName + "." +
indexTableName)).hasCoprocessor(GlobalIndexChecker.class.getName()));
+ } else {
+ if (mutable) {
+
Assert.assertTrue(admin.getDescriptor(TableName.valueOf(dataTableFullName)).hasCoprocessor(Indexer.class.getName()));
+
Assert.assertFalse(admin.getDescriptor(TableName.valueOf(dataTableFullName)).hasCoprocessor(IndexRegionObserver.class.getName()));
+ }
+
Assert.assertFalse(admin.getDescriptor(TableName.valueOf(schemaName + "." +
indexTableName)).hasCoprocessor(GlobalIndexChecker.class.getName()));
+ }
+ }
+ }
+
+ @Test
+ public void testToolWithMultiTablesMultiIndexes() throws Exception {
+
+ try(Connection conn = DriverManager.getConnection(getUrl(), new
Properties())) {
+ ConnectionQueryServices queryServices =
conn.unwrap(PhoenixConnection.class).getQueryServices();
+ Admin admin = queryServices.getAdmin();
+
+ ArrayList<String> args = new ArrayList<>();
+ args.add("-o");
+ if (upgrade) {
+ args.add("upgrade");
+ if (mutable) {
+ for (String table : tableList) {
+
Assert.assertTrue(admin.getDescriptor(TableName.valueOf(table)).hasCoprocessor(Indexer.class.getName()));
+
Assert.assertFalse(admin.getDescriptor(TableName.valueOf(table)).hasCoprocessor(IndexRegionObserver.class.getName()));
+ }
+ }
+ for (String index : indexesList) {
+
Assert.assertFalse(admin.getDescriptor(TableName.valueOf(index)).hasCoprocessor(GlobalIndexChecker.class.getName()));
+ }
+ } else {
+ args.add("rollback");
+ if (mutable) {
+ for (String table : tableList) {
+
Assert.assertTrue(admin.getDescriptor(TableName.valueOf(table)).hasCoprocessor(IndexRegionObserver.class.getName()));
+
Assert.assertFalse(admin.getDescriptor(TableName.valueOf(table)).hasCoprocessor(Indexer.class.getName()));
+ }
+ }
+ for (String index : indexesList) {
+
Assert.assertTrue(admin.getDescriptor(TableName.valueOf(index)).hasCoprocessor(GlobalIndexChecker.class.getName()));
+ }
+ }
+ args.add("-tb");
+ args.add(inputList);
+ args.add("-c");
+ args.add(conn.unwrap(PhoenixConnection.class).getURL());
+ IndexUpgradeTool.main(args.toArray(new String[args.size()]));
+ if (upgrade) {
+ if (mutable) {
+ for (String table : tableList) {
+
Assert.assertTrue(admin.getDescriptor(TableName.valueOf(table)).hasCoprocessor(IndexRegionObserver.class.getName()));
+
Assert.assertFalse(admin.getDescriptor(TableName.valueOf(table)).hasCoprocessor(Indexer.class.getName()));
+ }
+ }
+ for (String index : indexesList) {
+
Assert.assertTrue(admin.getDescriptor(TableName.valueOf(index)).hasCoprocessor(GlobalIndexChecker.class.getName()));
+ }
+ } else {
+ if (mutable) {
+ for (String table : tableList) {
+
Assert.assertTrue(admin.getDescriptor(TableName.valueOf(table)).hasCoprocessor(Indexer.class.getName()));
+
Assert.assertFalse(admin.getDescriptor(TableName.valueOf(table)).hasCoprocessor(IndexRegionObserver.class.getName()));
+ }
+ }
+ for (String index : indexesList) {
+
Assert.assertFalse(admin.getDescriptor(TableName.valueOf(index)).hasCoprocessor(GlobalIndexChecker.class.getName()));
+ }
+ }
+ }
+ }
+
Review comment:
What about a test for a table with one mutable and one immutable index?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
