dbwong commented on a change in pull request #518: PHOENIX-4285 Add
PHERF.LOG_PER_NROWS constraint to PHERF.properties file
URL: https://github.com/apache/phoenix/pull/518#discussion_r295565303
##########
File path: phoenix-pherf/src/test/java/org/apache/phoenix/pherf/PherfTest.java
##########
@@ -40,4 +44,23 @@ public void testUnknownOption() {
exit.expectSystemExitWithStatus(1);
Pherf.main(args);
}
+
Review comment:
I don't see a test for bad values of this passed in, non-integer negative
etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
