[
https://issues.apache.org/jira/browse/PHOENIX-5360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868162#comment-16868162
]
Hadoop QA commented on PHOENIX-5360:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12972258/PHOENIX-5360.patch
against master branch at commit 1f2508dbde365aaedac628c89df237e8b6b46df8.
ATTACHMENT ID: 12972258
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 2 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ // For the actual type of the coerceBytes call, we use
the node type instead of the rhs type, because
+ // for IN, the rhs type will be VARBINARY and no coerce
will be done in that case (and we need it to
+ // This can happen when an EQUAL operator is used and the
expression cannot possibly match.
+ // We have to take the range and condense it down to a
single key. We use which ever
+ // part of the range is inclusive (which implies being
bound as well). This works in all
+ // cases, including this substring one, which produces a
lower inclusive range and an
+ // FIXME: this is kind of a hack. The above call will fill
a fixed width key, but
+ // Don't use PDataType.pad(), as this only grows the
value, while this is shrinking it.
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexMetadataIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2687//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2687//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2687//console
This message is automatically generated.
> Cleanup anonymous inner classes in WhereOptimizer
> -------------------------------------------------
>
> Key: PHOENIX-5360
> URL: https://issues.apache.org/jira/browse/PHOENIX-5360
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Xinyi Yan
> Assignee: Xinyi Yan
> Priority: Minor
> Attachments: PHOENIX-5360.patch
>
>
> Followed [~gjacoby] in
> [PHOENIX-5024|https://issues.apache.org/jira/browse/PHOENIX-5024]. Convert
> Anonymous to Inne refactor in IntelliJ is the nice feature that converts
> anonymous to inner class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
