gjacoby126 commented on a change in pull request #518: PHOENIX-4285 Add
PHERF.LOG_PER_NROWS constraint to PHERF.properties file
URL: https://github.com/apache/phoenix/pull/518#discussion_r296942715
##########
File path: phoenix-pherf/src/test/java/org/apache/phoenix/pherf/PherfTest.java
##########
@@ -40,4 +44,48 @@ public void testUnknownOption() {
exit.expectSystemExitWithStatus(1);
Pherf.main(args);
}
+
+ @Test
+ public void testDefaultLogPerNRowsArgument() throws Exception {
+ String[] args = {"-listFiles"};
+ Pherf pherf = new Pherf(args);
+ Properties prop = pherf.getProperties();
+ assertEquals(Long.valueOf(PherfConstants.LOG_PER_NROWS),
Review comment:
Having a constant called LOG_PER_NROWS and another called LOG_PER_N_ROWS in
the same class is pretty confusing, especially when one refers to a key and the
other to a value. :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
