[ 
https://issues.apache.org/jira/browse/PHOENIX-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871887#comment-16871887
 ] 

Hadoop QA commented on PHOENIX-5368:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12972783/PHOENIX-5368.patch
  against master branch at commit 29e297748b3599ca1c53ee38d0fc67b63de0d27c.
  ATTACHMENT ID: 12972783

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 2 release 
audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +            buf.append(" and " + TABLE_SCHEM + (schemaPattern.length() == 
0 ? " is null" : " like ?" ));
+                buf.append(" and " + TABLE_SCHEM + (schemaPattern.length() == 
0 ? " is null" : " like ?" ));
+                whereClause.append(SEQUENCE_SCHEMA + (schemaPattern.length() 
== 0 ? " is null" : " like ?\n" ));

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2697//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2697//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2697//console

This message is automatically generated.

> Convert query statements in PhoenixDatabaseMetaData to prepared statements
> --------------------------------------------------------------------------
>
>                 Key: PHOENIX-5368
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5368
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: PHOENIX-5368.patch
>
>
> Currently, all table/schemas metadata APIs implemented in 
> PhoenixDatabaseMetaData using normal statements better to convert them to 
> prepared statements.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to