gjacoby126 commented on a change in pull request #526: PHOENIX-5374: Incorrect 
exception thrown in some cases when client does not have Exec permissions on 
SYSTEM:CATALOG
URL: https://github.com/apache/phoenix/pull/526#discussion_r298280744
 
 

 ##########
 File path: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/PermissionNSEnabledIT.java
 ##########
 @@ -50,4 +60,43 @@ public Void run() throws Exception {
             revokeAll();
         }
     }
+
+    @Test
+    public void testConnectionCreationFailsWhenNoExecPermsOnSystemCatalog() 
throws Throwable {
+        try {
+            grantSystemTableAccess();
+            superUser1.runAs((PrivilegedExceptionAction<Object>) () -> {
 
 Review comment:
   Patch looks fine for master, but isn't the "->" lambda operator a Java 8 
thing? If so you'll have to modify when backporting to 4.x, because from prior 
discussions on the dev list the community decided to keep 4.x compatible with 
JDK 7 because HBase 1.x is. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to