swaroopak commented on a change in pull request #520: PHOENIX-5333: A tool to
upgrade existing tables/indexes to use self-c…
URL: https://github.com/apache/phoenix/pull/520#discussion_r300486773
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -916,6 +916,9 @@ private void addCoprocessors(byte[] tableName,
TableDescriptorBuilder builder, P
} else if (indexRegionObserverEnabled &&
!newDesc.hasCoprocessor(GlobalIndexChecker.class.getName()) &&
!isLocalIndexTable(newDesc.getColumnFamilyNames())) {
builder.addCoprocessor(GlobalIndexChecker.class.getName(),
null, priority - 1, null);
+
if(newDesc.hasCoprocessor(IndexRegionObserver.class.getName())) {
+
builder.removeCoprocessor(IndexRegionObserver.class.getName());
Review comment:
@kadirozde this was added to remove the data table coprocessor that gets
added on an index table (it is similar to having indexer coproc (as per old
design) added to all the tables by default). Shall we do this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
