[
https://issues.apache.org/jira/browse/PHOENIX-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884125#comment-16884125
]
Hadoop QA commented on PHOENIX-5358:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12974551/PHOENIX-5358.master.v1.patch
against master branch at commit 9f2274bcd6cc272a5bb462a63aabb46956c4a79b.
ATTACHMENT ID: 12974551
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ String INDEX_REPAIR_FAILURE_TIME_DESC = "Histogram for the time in
milliseconds for index row repair failures";
+public class GlobalIndexCheckerSourceImpl extends BaseSourceImpl implements
GlobalIndexCheckerSource {
+ indexRepairFailures =
getMetricsRegistry().newCounter(INDEX_REPAIR_FAILURE,
INDEX_REPAIR_FAILURE_DESC, 0L);
+ indexRepairTimeHisto =
getMetricsRegistry().newHistogram(INDEX_REPAIR_TIME, INDEX_REPAIR_TIME_DESC);
+ indexRepairFailureTimeHisto =
getMetricsRegistry().newHistogram(INDEX_REPAIR_FAILURE_TIME,
INDEX_REPAIR_FAILURE_TIME_DESC);
+
metricsSource.updateIndexRepairTime(EnvironmentEdgeManager.currentTimeMillis()
- repairStart);
+
metricsSource.updateIndexRepairFailureTime(EnvironmentEdgeManager.currentTimeMillis()
- repairStart);
+ this.metricsSource =
MetricsIndexerSourceFactory.getInstance().getGlobalIndexCheckerSource();
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2774//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2774//console
This message is automatically generated.
> Metrics for the GlobalIndexChecker coprocessor
> ----------------------------------------------
>
> Key: PHOENIX-5358
> URL: https://issues.apache.org/jira/browse/PHOENIX-5358
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.13.1, 5.0.0, 4.15.0, 4.14.2
> Reporter: Kadir OZDEMIR
> Assignee: Priyank Porwal
> Priority: Major
> Fix For: 4.15.0, 5.1.0, 4.14.3
>
> Attachments: PHOENIX-5358.master.v1.patch
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The GlobalIndexChecker coprocessor is responsible for checking if an index
> row is "verified", that is, has completed its most recent two-phase write
> operation, during scans. If the row is not verified then the coprocessor
> rebuilds the row using a read-repair technique. The read-repair operations
> should be rare but add extra latency on the scan operations. We need to know
> how many read-repair operations happen and how long they take. Thus, we need
> metrics on them.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
