kadirozde commented on a change in pull request #531: PHOENIX-5385:
GlobalIndexChecker coproc doesn't load on view indexes
URL: https://github.com/apache/phoenix/pull/531#discussion_r303640390
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java
##########
@@ -837,14 +838,18 @@ public long getBatchCount() {
private final PName hTableName;
@Nonnull
private final TableRef origTableRef;
+ //This is a phoenix/logical table name
+ private String pTableFullName;
Review comment:
The question is then why is hTableName of type PName whereas pTableFullName
is of type String? Please note that PName is designed to be used as the name
type for objects in Phoenix (Phoenix Name for short). So, if you do not have
any specific reason to use String then you should use PName, especially here
for consistency. The type for pTableFullName is visible via the constructor
method, so it is not internal to this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
