[
https://issues.apache.org/jira/browse/PHOENIX-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886573#comment-16886573
]
Hadoop QA commented on PHOENIX-5383:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12974889/PHOENIX-5383.4.x-HBase-1.3.v1.patch
against 4.x-HBase-1.3 branch at commit
b5242ff75f18696ea29fe4c95fde27a5d557966d.
ATTACHMENT ID: 12974889
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
metricSource.updatePostIndexUpdateTime(EnvironmentEdgeManager.currentTimeMillis()
- start);
+
metricSource.updatePostIndexUpdateFailureTime(EnvironmentEdgeManager.currentTimeMillis()
- start);
+
metricSource.updatePreIndexUpdateFailureTime(EnvironmentEdgeManager.currentTimeMillis()
- start);
+ String PRE_INDEX_UPDATE_TIME_DESC = "Histogram for the time in milliseconds
for index updates pre data updates";
+ String POST_INDEX_UPDATE_TIME_DESC = "Histogram for the time in milliseconds
for index updates post data updates";
+ String PRE_INDEX_UPDATE_FAILURE_TIME_DESC = "Histogram for the time in
milliseconds on failures of index updates pre data updates";
+ String POST_INDEX_UPDATE_FAILURE_TIME_DESC = "Histogram for the time in
milliseconds on failures of index updates post data updates";
+ String POST_INDEX_UPDATE_FAILURE_DESC = "The number of failures of index
updates post data updates";
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2801//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2801//console
This message is automatically generated.
> Metrics for the IndexRegionObserver coprocesor
> ----------------------------------------------
>
> Key: PHOENIX-5383
> URL: https://issues.apache.org/jira/browse/PHOENIX-5383
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Priyank Porwal
> Assignee: Priyank Porwal
> Priority: Major
> Fix For: 4.15.0, 5.1.0, 4.14.3
>
> Attachments: PHOENIX-5383.4.x-HBase-1.3.v1.patch,
> PHOENIX-5383.master.v1.patch, PHOENIX-5383.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Need to track index write failures in phase1 and phase3 after the index
> re-design done as part of PHOENIX-5156 and -PHOENIX-5211.-
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
