[
https://issues.apache.org/jira/browse/PHOENIX-5302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886596#comment-16886596
]
Hadoop QA commented on PHOENIX-5302:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12974892/Phoenix-5302-4.x-HBase-1.3-v1.patch
against 4.x-HBase-1.3 branch at commit
b5242ff75f18696ea29fe4c95fde27a5d557966d.
ATTACHMENT ID: 12974892
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ PhoenixSysCatCreationServices(QueryServices services,
PhoenixEmbeddedDriver.ConnectionInfo connectionInfo, Properties info) {
+ // Conditions: server-side namespace mapping is enabled, the first
connection to the server will not create any
+ // Conditions: server-side namespace mapping is disabled, the first
connection to the server will not create any
+ // Expected: Since this is the first connection to the server, we will
immediately throw an exception for
+ createdNamespace =
ensureNamespaceCreated(QueryConstants.SYSTEM_SCHEMA_NAME);
+ // 1) If server-side namespace mapping is disabled,
drop the SYSTEM namespace if it was created
+ // 2) If server-side namespace mapping is enabled and
SYSTEM.CATALOG needs to be upgraded,
+ // upgrade SYSTEM.CATALOG and also migrate SYSTEM
tables to the SYSTEM namespace
+ // 3. If server-side namespace mapping is enabled and
SYSTEM.CATALOG doesn't need to be
+ // upgraded, we still need to migrate SYSTEM tables
to the SYSTEM namespace using the
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2803//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2803//console
This message is automatically generated.
> Different isNamespaceMappingEnabled for server / client causes
> TableNotFoundException
> -------------------------------------------------------------------------------------
>
> Key: PHOENIX-5302
> URL: https://issues.apache.org/jira/browse/PHOENIX-5302
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.2
> Reporter: Vincent Poon
> Assignee: Chinmay Kulkarni
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments: Phoenix-5302-4.x-HBase-1.3-v1.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Scenario:
> 1) Fresh cluster start with server isNamespaceMappingEnabled=true.
> 2) Client connects with isNamespaceMappingEnabled=false. Expected exception
> thrown ("Inconsistent namespace mapping")
> 3) Client connects with isNamespaceMappingEnabled=true. Exception: "Table
> undefined. tableName=SYSTEM.CATALOG"
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
