[ 
https://issues.apache.org/jira/browse/PHOENIX-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888235#comment-16888235
 ] 

Josh Elser commented on PHOENIX-5394:
-------------------------------------

{quote}AFAIK I ran all IT's using IDE
{quote}
Did you do this for all branches? The python driver not being included means 
that one of the ITs would definitely have never passed :)

It's ok – I was mad yesterday finding it in this situation. We'll figure it all 
out and fix it up. The lesson to learn is to double and triple check any time 
you're making massive changes to codebases like this :)

Can you take a look at the PR for me, please?

> Integration tests not running for phoenix-queryserver, general build cruft.
> ---------------------------------------------------------------------------
>
>                 Key: PHOENIX-5394
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5394
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Blocker
>             Fix For: queryserver-1.0.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Apparently no one tried to run the integration tests when the new repository 
> was made. They presently do not run on {{mvn verify}}.
> cc/ [~karanmehta93].
> I'm also seeing lots of unnecessary cruft that was pulled over from 
> phoenix.git which just unnecessarily complicates everything.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to