priyankporwal commented on a change in pull request #546: PHOENIX-5395:
IndexUpgradeTool passes data table instead of view for …
URL: https://github.com/apache/phoenix/pull/546#discussion_r305084409
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
##########
@@ -410,6 +405,19 @@ private void enableTable(Admin admin, String dataTable,
HashSet<String>indexes)
}
}
+ private void rebuildIndexes(Connection conn, Configuration conf, String
dataTableFullName) {
+ if (upgrade) {
+ prepareToRebuildIndexes(conn);
+ if(!test) {
+ indexingTool = new IndexTool();
+ }
+ indexingTool.setConf(conf);
+ rebuildIndexes(dataTableFullName, indexingTool);
+ }
+ }
+
+
Review comment:
Nit: Extra blank lines. Would be nice to stick to just 1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
