swaroopak commented on a change in pull request #546: PHOENIX-5395: 
IndexUpgradeTool passes data table instead of view for …
URL: https://github.com/apache/phoenix/pull/546#discussion_r305475192
 
 

 ##########
 File path: 
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
 ##########
 @@ -554,4 +551,99 @@ private boolean extractTablesAndIndexes(PhoenixConnection 
conn) {
             return false;
         }
     }
+
+    private void prepareToRebuildIndexes(Connection conn) {
+        try {
+            HashMap<String, IndexInfo> rebuildIndexes = new HashMap<>();
 
 Review comment:
   Thank you for the catch, passing the data table parameter to avoid 
recomputations 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to