kadirozde commented on a change in pull request #547: PHOENIX-5401 Error in 
running apache.phoenix.mapreduce.index.automati…
URL: https://github.com/apache/phoenix/pull/547#discussion_r305928342
 
 

 ##########
 File path: 
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixServerBuildIndexInputFormat.java
 ##########
 @@ -99,9 +98,6 @@ protected  QueryPlan getQueryPlan(final JobContext context, 
final Configuration
             if (txnScnValue != null) {
                 scan.setAttribute(BaseScannerRegionObserver.TX_SCN, 
Bytes.toBytes(Long.valueOf(txnScnValue)));
             }
-
-            // Initialize the query plan so it sets up the parallel scans
-            queryPlan.iterator(MapReduceParallelScanGrouper.getInstance());
 
 Review comment:
   The same step is done again after the calling this method so it is not 
necessary to do here. Please see the super class where this method is called. 
You can also looked at the default implementation of this method which does not 
this step and the other step that I removed above this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to