gokceni commented on a change in pull request #550: PHOENIX-5348: Fix flaky 
test: testIndexRebuildTask
URL: https://github.com/apache/phoenix/pull/550#discussion_r307537001
 
 

 ##########
 File path: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/DropTableWithViewsIT.java
 ##########
 @@ -166,9 +168,14 @@ public static void assertTaskColumns(Connection conn, 
String expectedStatus, PTa
         String taskStatus = rs.getString(PhoenixDatabaseMetaData.TASK_STATUS);
         assertEquals(expectedStatus, taskStatus);
 
+        if (expectedTableName != null) {
+            String tableName = 
rs.getString(PhoenixDatabaseMetaData.TABLE_NAME);
+            assertEquals(expectedTableName, tableName);
+        }
+
         if (expectedData != null) {
             String data = rs.getString(PhoenixDatabaseMetaData.TASK_DATA);
-            assertEquals(expectedData, data);
+            assertTrue(data.contains(expectedData));
 
 Review comment:
   Key is a bit complicated:
   PRIMARY KEY (" + TASK_TYPE + "," + TASK_TS + " ROW_TIMESTAMP," + TENANT_ID + 
"," + TABLE_SCHEM + "," +
               TABLE_NAME + "))
   I will try to move to key

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to