swaroopak commented on a change in pull request #559: PHOENIX-5419: Converting 
anonymous to inner class in TracingQueryPlan
URL: https://github.com/apache/phoenix/pull/559#discussion_r309522605
 
 

 ##########
 File path: 
phoenix-core/src/main/java/org/apache/phoenix/compile/TraceQueryPlan.java
 ##########
 @@ -295,4 +236,71 @@ public Long getEstimateInfoTimestamp() throws 
SQLException {
     public List<OrderBy> getOutputOrderBys() {
         return Collections.<OrderBy> emptyList();
     }
+
+    private class QueryResultIterator implements ResultIterator {
 
 Review comment:
   nit: could you please rename the private class to TraceQueryResultIterator?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to