swaroopak commented on a change in pull request #554: PHOENIX-5390 Changing
anonymous inner classes in phoenix-core/main
URL: https://github.com/apache/phoenix/pull/554#discussion_r309528582
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/PrefixFunction.java
##########
@@ -52,26 +50,34 @@ protected boolean extractNode() {
@Override
public KeyPart newKeyPart(final KeyPart childPart) {
- return new KeyPart() {
- private final List<Expression> extractNodes = extractNode() ?
Collections.<Expression>singletonList(PrefixFunction.this) :
Collections.<Expression>emptyList();
+ return new PrefixKeyPart(childPart);
+ }
- @Override
- public PColumn getColumn() {
- return childPart.getColumn();
- }
+ private class PrefixKeyPart implements KeyPart {
+ private final List<Expression> extractNodes = extractNode() ?
Collections.<Expression>singletonList(PrefixFunction.this) :
Collections.<Expression>emptyList();
Review comment:
this ll give you line length warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
