[
https://issues.apache.org/jira/browse/PHOENIX-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899190#comment-16899190
]
Hadoop QA commented on PHOENIX-5420:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12976574/PHOENIX-5420.master.v2.patch
against master branch at commit 12c538ce2db4779b91bc294ebe8e4880673ff8c2.
ATTACHMENT ID: 12976574
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ ResultSet rs = conn.createStatement().executeQuery("SELECT
TRIMB(b,cast('AB' as VARBINARY)),TRIMB(vb,cast('A' as VARBINARY)) FROM "
+ + " WHERE TRIMB(b,cast('AB' as
VARBINARY))='CD' and TRIMB(vb,cast('A' as VARBINARY))='BCD'");
+ ResultSet rs = conn.createStatement().executeQuery( "SELECT
TRIMB(b,cast('D' as VARBINARY)),TRIMB(vb,cast('BCD' as VARBINARY)) FROM "
+ + " WHERE TRIMB(b,cast('D' as
VARBINARY))='ABC' and TRIMB(vb,cast('BCD' as VARBINARY))='A'");
+ "SELECT TRIMB(b,cast('AB' as
VARBINARY)),TRIMB(vb,cast('ABD' as VARBINARY)) FROM "
+ + " WHERE TRIMB(b,cast('AB' as VARBINARY))='D'
and TRIMB(vb,cast('ABD' as VARBINARY))='CDEFBCEFC'");
+ "SELECT TRIMB(b,cast('AAA' as
VARBINARY)),TRIMB(vb,cast('AABB' as VARBINARY)) FROM "
+ + " WHERE TRIMB(b,cast('AAA' as
VARBINARY))='CC' and TRIMB(vb,cast('AABB' as VARBINARY))='CDEFBCEFC'");
+ "SELECT TRIMB(b,cast(' C' as
VARBINARY)),TRIMB(b,cast('C' as VARBINARY)),TRIMB(vb,cast(' C' as VARBINARY))
FROM "
+ + " WHERE TRIMB(b,cast(' C' as VARBINARY))='B'
and TRIMB(b,cast('C' as VARBINARY))=' BC ' and TRIMB(vb,cast(' C' as
VARBINARY))='B'");
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.expression.TrimbFunctionTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2867//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2867//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2867//console
This message is automatically generated.
> Implement trimb build-in function for BINARY and VARBINARY
> ----------------------------------------------------------
>
> Key: PHOENIX-5420
> URL: https://issues.apache.org/jira/browse/PHOENIX-5420
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Vikash Talanki
> Assignee: Vikash Talanki
> Priority: Major
> Labels: beginner, features, newbie, patch
> Attachments: PHOENIX-5420.master.v2.patch
>
>
> see https://issues.apache.org/jira/browse/PHOENIX-2158
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
