dbwong commented on a change in pull request #567: PHOENIX-5134 Phoenix
Connection Driver #normalize does not distinguis…
URL: https://github.com/apache/phoenix/pull/567#discussion_r314531651
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixEmbeddedDriver.java
##########
@@ -505,8 +519,21 @@ public ConnectionInfo(String zookeeperQuorum, Integer
port, String rootNode, Str
if (null == this.user) {
throw new RuntimeException("Acquired null user which should
never happen");
}
+ this.tenantID = tenantID;
}
-
+
+ public static String getTenantID(String url) {
Review comment:
Public function should have javadoc. Also this clearly returns null
Strings. Consider Optional to enforce callers handle those cases. While this
can be static, why are we treating this differently than getPort, etc and then
just returning the tenantID? Also will make future mocking simpler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
