swaroopak commented on a change in pull request #567: PHOENIX-5134 Phoenix
Connection Driver #normalize does not distinguis…
URL: https://github.com/apache/phoenix/pull/567#discussion_r314860765
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixEmbeddedDriver.java
##########
@@ -304,15 +304,22 @@ public static ConnectionInfo create(String url) throws
SQLException {
}
}
}
- return new ConnectionInfo(quorum,port,rootNode, principal,
keytabFile);
+ return new ConnectionInfo(quorum,port,rootNode, principal,
keytabFile,
+ getTenantIDParser(url));
}
-
+
public ConnectionInfo normalize(ReadOnlyProps props, Properties info)
throws SQLException {
+ return normalize(props, info, null);
+ }
+
+ public ConnectionInfo normalize(ReadOnlyProps props, Properties info,
String url)
+ throws SQLException {
String zookeeperQuorum = this.getZookeeperQuorum();
Integer port = this.getPort();
String rootNode = this.getRootNode();
String keytab = this.getKeytab();
String principal = this.getPrincipal();
+ String tenantID = this.getTenantID();
Review comment:
nit: use tenantId instead of tenantID (ref:
https://google.github.io/styleguide/javaguide.html#s5.3-camel-case)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
