[
https://issues.apache.org/jira/browse/PHOENIX-5167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911232#comment-16911232
]
Hadoop QA commented on PHOENIX-5167:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12978037/PHOENIX-5167.master.v4.patch
against master branch at commit 4e65c902539be485ef911cd3f4e6dd726672c9c5.
ATTACHMENT ID: 12978037
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.hadoop.hbase.regionserver.wal.WALRecoveryRegionPostOpenIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2919//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2919//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2919//console
This message is automatically generated.
> Fix LGTM alerts
> ---------------
>
> Key: PHOENIX-5167
> URL: https://issues.apache.org/jira/browse/PHOENIX-5167
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Malcolm Taylor
> Priority: Major
> Labels: phoenix-hardening
> Attachments: PHOENIX-5167.master.v1.patch,
> PHOENIX-5167.master.v2.patch, PHOENIX-5167.master.v3.patch,
> PHOENIX-5167.master.v4.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I work for Semmle, the company behind LGTM. During our analysis of
> apache/phoenix, LGTM raised some alerts
> ([https://lgtm.com/projects/g/apache/phoenix/alerts/?mode=tree).]
> This issue is to fix some of the more straightforward ones.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
