[
https://issues.apache.org/jira/browse/PHOENIX-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916260#comment-16916260
]
Hadoop QA commented on PHOENIX-4743:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12978622/PHOENIX-4743-4.x-HBase-1.3.patch
against 4.x-HBase-1.3 branch at commit
43310a6dc69433d3df772e17d48fe4d8821d40ac.
ATTACHMENT ID: 12978622
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 3 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ HTableDescriptor originalDesc =
admin.getTableDescriptor(Bytes.toBytes(globalIndexTableName));
+ HTableDescriptor finalDesc =
admin.getTableDescriptor(Bytes.toBytes(globalIndexTableName));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.OrderByWithSpillingIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2928//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2928//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2928//console
This message is automatically generated.
> ALTER TABLE ADD COLUMN for global index should not modify HBase metadata if
> failed
> ----------------------------------------------------------------------------------
>
> Key: PHOENIX-4743
> URL: https://issues.apache.org/jira/browse/PHOENIX-4743
> Project: Phoenix
> Issue Type: Bug
> Reporter: Chinmay Kulkarni
> Assignee: Sandeep Pal
> Priority: Major
> Labels: phoenix-hardening
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-4743-4.x-HBase-1.3.patch, PHOENIX-4743.patch,
> PHOENIX-4743.v1.patch, PHOENIX-4743.v3.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> When you issue an "ALTER TABLE" for a global index to add a column, Phoenix
> throws a SQLException, but the HBase metadata for the global index table is
> still modified.
> Steps to reproduce:
> * Create the base data table:
> {code:java}
> create table if not exists z_base_table (id INTEGER not null primary key,
> host VARCHAR(10), flag boolean);{code}
> * Create a global index on top of this table:
> {code:java}
> create index global_z_index on z_base_table(HOST);{code}
> * Add a column to the global index table:
> {code:java}
> alter table global_z_index add cf1.age INTEGER;{code}
> This will throw an exception in Phoenix, but HBase metadata for the global
> index table is still modified. Stack trace:
> {noformat}
> Error: ERROR 1010 (42M01): Not allowed to mutate table. Cannot add/drop
> column referenced by VIEW columnName=GLOBAL_Z_INDEX (state=42M01,code=1010)
> java.sql.SQLException: ERROR 1010 (42M01): Not allowed to mutate table.
> Cannot add/drop column referenced by VIEW columnName=GLOBAL_Z_INDEX
> at
> org.apache.phoenix.exception.SQLExceptionCode$Factory$1.newException(SQLExceptionCode.java:494)
> at
> org.apache.phoenix.exception.SQLExceptionInfo.buildException(SQLExceptionInfo.java:150)
> at
> org.apache.phoenix.schema.MetaDataClient.processMutationResult(MetaDataClient.java:3049)
> at
> org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3503)
> at
> org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3210)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$ExecutableAddColumnStatement$1.execute(PhoenixStatement.java:1432)
> at org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:408)
> at org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:391)
> at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:390)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:378)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:1825)
> at sqlline.Commands.execute(Commands.java:822)
> at sqlline.Commands.sql(Commands.java:732)
> at sqlline.SqlLine.dispatch(SqlLine.java:813)
> at sqlline.SqlLine.begin(SqlLine.java:686)
> at sqlline.SqlLine.start(SqlLine.java:398)
> at sqlline.SqlLine.main(SqlLine.java:291{noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
