[
https://issues.apache.org/jira/browse/PHOENIX-5454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917670#comment-16917670
]
Hadoop QA commented on PHOENIX-5454:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12978754/PHOENIX-5454.master.v1.patch
against master branch at commit 197b6e30c894b657758c5d0cb3c6182d6c8d4723.
ATTACHMENT ID: 12978754
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation, build,
or dev patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 3 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2930//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2930//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2930//console
This message is automatically generated.
> Phoenix scripts start foreground java processes as child processes
> ------------------------------------------------------------------
>
> Key: PHOENIX-5454
> URL: https://issues.apache.org/jira/browse/PHOENIX-5454
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.1.0
> Reporter: István Tóth
> Assignee: István Tóth
> Priority: Minor
> Attachments: PHOENIX-5454.master.v1.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the phoenix scripts in python start the java process via
> subprocess.call() or subprocess.popen() even when the java process has to run
> in the foreground, and there is no cleanup required.
> I propose that in these cases, we start java via os.exec*(). This has the
> following advantages:
> * There is no python process idling waiting for the java process to end,
> reducing process count and memory consumption
> * Signal handling is simplified (signals sent to the starting script are
> received by the java process started)
> * Return code handling is simplified (no need to check for and return error
> codes from java in the startup script)
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
