[ 
https://issues.apache.org/jira/browse/PHOENIX-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922599#comment-16922599
 ] 

Josh Elser commented on PHOENIX-5428:
-------------------------------------

No worries on justifying QA report. It's obvious your changes are not related 
to its complaints :)

I see some other stuff we could improve, but this plugin upgrade seems fine to 
me. Will commit.

> Upgrade maven-checkstyle-plugin version
> ---------------------------------------
>
>                 Key: PHOENIX-5428
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5428
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: István Tóth
>            Assignee: István Tóth
>            Priority: Minor
>         Attachments: PHOENIX-5428.master.v1.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Phoenix uses an old maven-checkstyle-plugin version, and accordingly an old 
> checker.xml file.
> This checker.xml file is not understood by recent checkstyle versions, 
> including the one used by the current eclipse checkstyle plugin, so (at 
> least) eclipse checkstyle integration has stopped working.
> Updating to the latest maven-checkstyle-plugin, and updating the checkstyle 
> config files accordingly solves this problem.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to