[ 
https://issues.apache.org/jira/browse/PHOENIX-5505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945197#comment-16945197
 ] 

Lars Hofhansl commented on PHOENIX-5505:
----------------------------------------

I don't know enough about this code to say whether the addendum is correct. 
Looks good as far as I can tell.
+1 as long as it fixes the tests.

> Index read repair does not repair unverified rows with higher timestamp 
> ------------------------------------------------------------------------
>
>                 Key: PHOENIX-5505
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5505
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.0.0, 4.15.0, 4.14.3
>            Reporter: Kadir Ozdemir
>            Assignee: Kadir OZDEMIR
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0, 4.14.3
>
>         Attachments: PHOENIX-5505.master.001.patch, 
> PHOENIX-5505.master.002.patch, PHOENIX-5505.master.003.patch, 
> PHOENIX-5505.master.004.patch, PHOENIX-5505.master.addendum.patch
>
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> Read repair (GlobalIndexChecker) sets the time range for the scan on the data 
> table for using the timestamp of the index table row to be repaired. The 
> start time for the scan is the timestamp of the index row in the current 
> implementation. However, if the index row timestamp is higher than the data 
> table row timestamp, then the data table row will not be visible to the scan. 
> The index row timestamp can be higher when the index row is overwritten with 
> the unverified row status (in the first write phase) but the data table row 
> is not overwritten (in the second write phase) due to a failure. In this 
> case, the unverified index row will not be rebuilt and will be deleted 
> eventually.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to