gjacoby126 commented on a change in pull request #598: PHOENIX-5515 Able to
write indexed value to data table without writin…
URL: https://github.com/apache/phoenix/pull/598#discussion_r334201201
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/IndexWriter.java
##########
@@ -131,25 +131,6 @@ public IndexWriter(IndexCommitter committer,
IndexFailurePolicy policy,
this.writer = committer;
this.failurePolicy = policy;
}
-
- /**
- * Write the mutations to their respective table.
- * <p>
- * This method is blocking and could potentially cause the writer to block
for a long time as we
- * write the index updates. When we return depends on the specified {@link
IndexCommitter}.
- * <p>
- * If update fails, we pass along the failure to the installed {@link
IndexFailurePolicy}, which
- * then decides how to handle the failure.
- * @param indexUpdates Updates to write
- * @param clientVersion version of the client
- * @throws IOException
- */
- public void writeAndHandleFailure(Collection<Pair<Mutation, byte[]>>
indexUpdates,
Review comment:
What about indexes using the old design? Shouldn't they get disabled / use
the old failure policies until they're upgraded?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
