kadirozde commented on a change in pull request #598: PHOENIX-5515 Able to
write indexed value to data table without writin…
URL: https://github.com/apache/phoenix/pull/598#discussion_r334207030
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/TrackingParallelWriterIndexCommitter.java
##########
@@ -242,8 +243,13 @@ private void throwFailureIfDone() throws
SingleIndexWriteFailureException {
// if any of the tasks failed, then we need to propagate the failure
if (failures.size() > 0) {
// make the list unmodifiable to avoid any more synchronization
concerns
- throw new
MultiIndexWriteFailureException(Collections.unmodifiableList(failures),
+ MultiIndexWriteFailureException exception = new
MultiIndexWriteFailureException(Collections.unmodifiableList(failures),
disableIndexOnFailure &&
PhoenixIndexFailurePolicy.getDisableIndexOnFailure(env));
+ if (disableIndexOnFailure)
+ throw exception;
+ else {
+ throw new DoNotRetryIOException(exception.getMessage());
Review comment:
I will do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
