[
https://issues.apache.org/jira/browse/PHOENIX-5515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949873#comment-16949873
]
Hadoop QA commented on PHOENIX-5515:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12982823/PHOENIX-5515.master.001.patch
against master branch at commit bf30a40006e15b60eb140c974dc4317e4e83de75.
ATTACHMENT ID: 12982823
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ // Configure IndexRegionObserver to fail the last write phase
(i.e., the post index update phase) where the verify flag is set
+ // to true and/or index rows are deleted and check that this does
not impact the correctness
+ // The index rows are actually not deleted yet because
IndexRegionObserver failed delete operation. However, they are
+ // This DML will scan the Index table and detect unverified index
rows. This will trigger read repair which
+ // result in deleting these rows since the corresponding data
table rows are deleted already. So, the number of
+ // rows to be deleted by the "DELETE" DML will be zero since the
rows deleted by read repair will not be visible
+ // Configure IndexRegionObserver to fail the first write phase
(i.e., the pre index update phase). This should not
+ conn.createStatement().execute("upsert into " + dataTableName + "
(id, val2) values ('a', 'abcc')");
+ conn.createStatement().execute("upsert into " + dataTableName + "
(id, val1, val2) values ('c', 'cd','cde')");
+ populateTable(dataTableName); // with two rows ('a', 'ab', 'abc',
'abcd') and ('b', 'bc', 'bcd', 'bcde')
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.SubqueryUsingSortMergeJoinIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3014//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3014//console
This message is automatically generated.
> Able to write indexed value to data table without writing to index table
> ------------------------------------------------------------------------
>
> Key: PHOENIX-5515
> URL: https://issues.apache.org/jira/browse/PHOENIX-5515
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.3
> Reporter: Vincent Poon
> Assignee: Kadir OZDEMIR
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-5515.master.001.patch
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Using the 4.14.3 client, it still seems the IndexFailurePolicy is still
> kicking in, which disables the index on write failure. This means that while
> the index is in 'disabled' state, writes to the data table can happen without
> any writes to the index table. While in theory this might be ok since the
> rebuilder should eventually kick in and rebuild from the disable_timestamp,
> this breaks the new indexing design invariant that there should be no data
> table rows without a corresponding index row (potentially unverified), so
> this could potentially cause some unexpected behavior.
> Steps to repro:
> 1) Create data table
> 2) Create index table
> 3) "close_region" on index region from hbase shell
> 4) Upsert to data table
> Eventually after some number of retries, the index will get disabled, which
> means any other client can write to the data table without writing to the
> index table.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
