[
https://issues.apache.org/jira/browse/PHOENIX-5464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951283#comment-16951283
]
Hadoop QA commented on PHOENIX-5464:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12982979/PHOENIX-5464.master.001.patch
against master branch at commit f431f1be1f3c17dba75adfce0873848c983af82c.
ATTACHMENT ID: 12982979
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ if
(CellComparator.getInstance().compareTimestamps(current, emptyColumnCell) < 0) {
+ // dataSupplier.upsertValues column positions to be
used for partial updates.
+ // COL3 is the include column for the table index in
this schema => index pos of 2
+ // COL6 is the include column for the global view
index => index pos of 2
+ // COL7 is the include column for the tenant view
index => index pos of 0
+ // A Data Writer to be used in tests to upsert sample data (@see
TestDataSupplier) into the sample schema.
+ "useTenantConnectionForGlobalView and
useGlobalConnectionOnly both cannot be true");
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.LocalImmutableNonTxIndexIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3018//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3018//console
This message is automatically generated.
> Verify that the EMPTY_COLUMN column is updated under various scenarios in
> hbase.
> --------------------------------------------------------------------------------
>
> Key: PHOENIX-5464
> URL: https://issues.apache.org/jira/browse/PHOENIX-5464
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Jacob Isaac
> Assignee: Jacob Isaac
> Priority: Major
> Fix For: 4.15.1, 5.1.1
>
> Attachments: PHOENIX-5464.4.x.HBase1-3.001.patch,
> PHOENIX-5464.master.001.patch
>
>
> We plan to use the timestamp of the EMPTY_COLUMN to support TTL for views.
> Since each column in HBase can have a different timestamp depending on when
> it gets updated. The timestamp of the EMPTY_COLUMN can serve as the timestamp
> of the row (a row in PHOENIX) and can be used to determine TTL expiration of
> a row in PHOENIX.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
