gokceni commented on a change in pull request #597: PHOENIX-5522 If index is
disabled, IndexUpgradeTool should not fail d…
URL: https://github.com/apache/phoenix/pull/597#discussion_r335088285
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java
##########
@@ -111,18 +119,13 @@ public void setup () throws Exception {
}
private void setClusterProperties() {
- // we need to destroy the cluster if it was initiated using property
as true
- if (Boolean.toString(upgrade).equals(clientProps
- .get(QueryServices.INDEX_REGION_OBSERVER_ENABLED_ATTRIB))
- || Boolean.toString(!isNamespaceEnabled).equals(serverProps
- .get(QueryServices.IS_NAMESPACE_MAPPING_ENABLED))) {
- tearDownMiniClusterAsync(1);
- }
+ tearDownMiniClusterAsync(1);
+
//setting up properties for namespace
clientProps.put(QueryServices.IS_NAMESPACE_MAPPING_ENABLED,
- Boolean.toString(isNamespaceEnabled));
+ Boolean.toString(true));
Review comment:
Sure but I think it is good to test with namespace just to cover that too.
We need to pick either. I thought this is a safer approach to test that
scenario too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
