[
https://issues.apache.org/jira/browse/PHOENIX-5522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953218#comment-16953218
]
Hadoop QA commented on PHOENIX-5522:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12983210/PHOENIX-5522.master.001.patch
against master branch at commit eebccf59a2a19ff2d3b328b113117c7e6685e75e.
ATTACHMENT ID: 12983210
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ private static final String [] TABLE_LIST =
{"TEST.MOCK1","TEST1.MOCK2","TEST.MOCK3","TEST.MULTI_TENANT_TABLE"};
+ private static final String INPUT_LIST =
"TEST.MOCK1,TEST1.MOCK2,TEST.MOCK3,TEST.MULTI_TENANT_TABLE";
+ "CREATE TABLE TEST.MULTI_TENANT_TABLE " + " (TENANT_ID
VARCHAR(15) NOT NULL,ID INTEGER NOT NULL"
+ + ", NAME VARCHAR, CONSTRAINT PK_1 PRIMARY KEY
(TENANT_ID, ID)) MULTI_TENANT=true";
+ conn.createStatement().execute("CREATE INDEX MOCK1_INDEX1 ON
TEST.MOCK1_VIEW1 " + "(view_column)");
+ conn.createStatement().execute("CREATE INDEX MOCK2_INDEX1 ON
TEST1.MOCK2_VIEW " + "(state, city)");
+ conn.createStatement().execute("CREATE INDEX MOCK1_INDEX3 ON
TEST.MOCK1_VIEW " + "(view_column)");
+ connTenant.createStatement().execute("CREATE INDEX MULTI_TENANT_INDEX
ON TEST.TEST_TENANT_VIEW (NAME)");
+ connTenant.createStatement().execute("ALTER INDEX MULTI_TENANT_INDEX
ON TEST.TEST_TENANT_VIEW DISABLE");
+ public ParameterizedIndexUpgradeToolIT(boolean mutable, boolean upgrade,
boolean isNamespaceEnabled) {
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3030//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3030//console
This message is automatically generated.
> IndexUpgradeTool needs to take into account already Disabled indexes during
> upgrade
> -----------------------------------------------------------------------------------
>
> Key: PHOENIX-5522
> URL: https://issues.apache.org/jira/browse/PHOENIX-5522
> Project: Phoenix
> Issue Type: Bug
> Reporter: Gokcen Iskender
> Assignee: Gokcen Iskender
> Priority: Major
> Attachments: PHOENIX-5522.master.001.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> IndexUpgradeTool runs IndexTool to rebuild indexes. IndexTool directly
> converts the state to Active after it is done. Disabled->Active transition is
> not possible, so it will fail to convert the index state and index will stay
> disabled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
