ChinmaySKulkarni edited a comment on issue #599: Create columns in SYSCAT and fields in PTable.proto for view TTL support URL: https://github.com/apache/phoenix/pull/599#issuecomment-543973419 @jpisaac @yanxinyi One thing to keep in mind is, this requires a schema change for SYSTEM.CATALOG, so we should handle this in the `upgradeSystemTables` path as well. This will be mandatory since this affects the `createTable` and other client side code which expects these columns to be present in SYSTEM.CATALOG. One bummer is, we only do such schema upgrades during a major or minor version upgrade i.e. 4.x to 4.(x+1). Now since this isn't in 4.15.0, we can't push it into 4.15.x either, otherwise clients that upgrade from 4.15.0 to 4.15.x won't get the new SYSTEM.CATALOG schema. Which means, this needs to go into 4.16.0. In case we want this to go into 4.15.x, one (ugly) way to avoid this is to add a tool that adds these extra columns and document that users need to run this before being able to use 4.15.x.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
