kadirozde commented on a change in pull request #600: PHOENIX-5535 Index
rebuilds via UngroupedAggregateRegionObserver shou…
URL: https://github.com/apache/phoenix/pull/600#discussion_r337292658
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
##########
@@ -1111,7 +1125,7 @@ private RegionScanner rebuildIndices(final RegionScanner
innerScanner, final Reg
synchronized (innerScanner) {
do {
List<Cell> results = new ArrayList<Cell>();
- hasMore = innerScanner.nextRaw(results);
+ hasMore = newScanner.nextRaw(results);
Review comment:
Yes, the above changes will be no-op for partial rebuilds by
MetaDataRegionObserver and GlobalIndexChecker. The changes are only for
rebuilds by IndexTool and index create (both using ServerIndexBuildComplier).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
