kadirozde commented on issue #602: PHOENIX-5535 Index rebuilds via UngroupedAggregateRegionObserver shou… URL: https://github.com/apache/phoenix/pull/602#issuecomment-545079616 @gjacoby126, The rebuilds are done by scanning tables using UngroupedAggregateRegionObserver which implements the server side of AggregatePlan. A "SELECT COUNT(*)" statement is compiled to an aggregate plan. Before this JIRA, I was generating an aggregate plan using this select statement. This plan uses regular scan. Turning this scan into raw scan did not work as the filter set on the scan for this aggregate plan was not compatible with raw scans. So, I hacked it by using ""SELECT *" and setting scan.setAttribute(BaseScannerRegionObserver.UNGROUPED_AGG, TRUE_BYTES). This worked with raw scan but caused permission IT failures. I tried to find out the reason for this failure but it was not obvious. So then I followed exactly what MetaDataRegionObserver for partial rebuilds which also uses PostDDLCompiler and raw scan. In a way, we have better unification between partial rebuilds and full rebuilds now. Actually, this was my very first patch that I posted. However, it was more involved than what I wanted (or thought so) and I removed it and came up with the first one you reviewed. So, I made a circle :-)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
