[
https://issues.apache.org/jira/browse/PHOENIX-5543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959287#comment-16959287
]
Hadoop QA commented on PHOENIX-5543:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12983955/PHOENIX-5543.master.v1.patch
against master branch at commit f3f722e4f29293885f1854cca9dd4cd37e6ff085.
ATTACHMENT ID: 12983955
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ String secondTenantConnectionURL =
PHOENIX_JDBC_TENANT_SPECIFIC_URL.replace(TENANT_ID, tenantId2);
+ createTestTable(secondTenantConnectionURL,
TENANT_TABLE_DDL.replace(TENANT_TABLE_NAME, tenantTable2));
+ String secondTenantConnectionURL =
PHOENIX_JDBC_TENANT_SPECIFIC_URL.replace(TENANT_ID, tenantId2);
+ createTestTable(secondTenantConnectionURL,
TENANT_TABLE_DDL.replace(TENANT_TABLE_NAME, tenantTable2));
+ : SHOW TABLES (IN schema=identifier)? (LIKE pattern=string_literal)? {
$ret = factory.showTablesStatement(schema, pattern); }
+ | SHOW SCHEMAS (LIKE pattern=string_literal)? { $ret =
factory.showSchemasStatement(pattern); }
+ PreparedStatement stmt = QueryUtil.getIndexInfoStmt(connection,
catalog, schema, table, unique, approximate);
+ PreparedStatement stmt = QueryUtil.getSuperTablesStmt(connection,
catalog, schemaPattern, tableNamePattern);
+ PreparedStatement stmt = QueryUtil.getTablesStmt(connection, catalog,
schemaPattern, tableNamePattern, types);
+ private static class ExecutableShowTablesStatement extends
ShowTablesStatement implements CompilableStatement {
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3066//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3066//console
This message is automatically generated.
> Implement show schemas / show tables SQL commands
> -------------------------------------------------
>
> Key: PHOENIX-5543
> URL: https://issues.apache.org/jira/browse/PHOENIX-5543
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Bharath Vissapragada
> Assignee: Bharath Vissapragada
> Priority: Minor
> Attachments: PHOENIX-5543.master.v1.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently users rely on {{!tables}} and {{!schemas}} commands provided by
> sqlline which pulls the information using the standard JDBC metadata calls
> like {{getTables()}} and {{getSchemas()}}.
> Most other databases (like mysql[1,2]) implement these as first class SQL
> commands that gives the user more flexibility in querying by adding necessary
> filters and looking up for table information in specific schemas. The ask
> here is to implement the following SQL commands.
> {noformat}
> SHOW SCHEMAS [LIKE '<pattern>']
> SHOW TABLES [IN <schema>] [LIKE '<pattern>']
> {noformat}
> [1] https://dev.mysql.com/doc/refman/8.0/en/show-tables.html
> [2] https://dev.mysql.com/doc/refman/8.0/en/show-databases.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
