[ 
https://issues.apache.org/jira/browse/PHOENIX-5540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960223#comment-16960223
 ] 

Hadoop QA commented on PHOENIX-5540:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12984059/PHOENIX-5540.4x-1.4.001.patch
  against master branch at commit e5373e5d6e109cce577381e3672218a2eb978641.
  ATTACHMENT ID: 12984059

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +            createAndPopulateTableAndIndexForConsistentIndex(conn, 
fullTableName, fullIndexName, 0, null);
+            ResultSet rs = conn.createStatement().executeQuery("SELECT /*+ 
NO_INDEX */ COUNT(*) FROM " + TABLE_NAME);
+        public void 
preBatchMutate(ObserverContext<RegionCoprocessorEnvironment> c, 
MiniBatchOperationInProgress<Mutation> miniBatchOp) throws
+                        unverifiedPut.addColumn(emptyCF, emptyCQ, timestamp, 
IndexRegionObserver.UNVERIFIED_BYTES);
+                        // Remove the empty column prepared by Index codec as 
we need to change its value

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexRebuildTaskIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3073//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3073//console

This message is automatically generated.

> Full row index write at the last write phase for immutable global indexes
> -------------------------------------------------------------------------
>
>                 Key: PHOENIX-5540
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5540
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 5.0.0, 4.15.0
>            Reporter: Kadir OZDEMIR
>            Assignee: Gokcen Iskender
>            Priority: Major
>         Attachments: PHOENIX-5540.4x-1.4.001.patch, 
> PHOENIX-5540.master.001.patch, PHOENIX-5540.master.002.patch
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> See PHOENIX-5539 for the reason for this improvement.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to