[
https://issues.apache.org/jira/browse/PHOENIX-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961542#comment-16961542
]
Hudson commented on PHOENIX-5541:
---------------------------------
FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.4 #294 (See
[https://builds.apache.org/job/Phoenix-4.x-HBase-1.4/294/])
PHOENIX-5541 - Redundant Global Mutable Index Writes on Legacy Indexer
(gjacoby: rev e3f226518fd5afba5fa9a409d81c9f7e2da50598)
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/IndexWriter.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java
> Redundant Global Mutable Index Writes on Legacy Indexer
> -------------------------------------------------------
>
> Key: PHOENIX-5541
> URL: https://issues.apache.org/jira/browse/PHOENIX-5541
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0, 5.1.0, 4.14.3
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Fix For: 5.1.0, 4.15.1, 4.14.4
>
> Attachments: PHOENIX-5541.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In the inaccurately-named IndexWriter.writeAndKillYourselfOnFailure, there's
> the following code:
> {code:java}
> public void writeAndKillYourselfOnFailure(Collection<Pair<Mutation, byte[]>>
> indexUpdates, boolean allowLocalUpdates, int clientVersion) throws
> IOException {
> // convert the strings to htableinterfaces to which we can talk and group by
> TABLE Multimap<HTableInterfaceReference, Mutation> toWrite =
> resolveTableReferences(indexUpdates);
> writeAndKillYourselfOnFailure(toWrite, allowLocalUpdates, clientVersion);
> writeAndHandleFailure(toWrite, allowLocalUpdates, clientVersion);
> }
> {code}
> writeAndKillYourselfOnFailure and writeAndHandleFailure seem to be identical,
> which means that calling them both will result in the same index Cells being
> written twice. This shouldn't affect correctness, but it will affect
> performance and (temporarily, until compaction) storage
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
