gokceni commented on a change in pull request #611: PHOENIX-5535 Replay delete
markers during server side global index re…
URL: https://github.com/apache/phoenix/pull/611#discussion_r339842009
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
##########
@@ -1146,6 +1154,45 @@ private void setMutationAttributes(Mutation m, byte[]
uuidValue) {
m.setDurability(Durability.SKIP_WAL);
}
+ private Delete generateDeleteMarkers(List<Cell> row) {
+ Set<ColumnReference> allColumns = indexMaintainer.getAllColumns();
+ if (row.size() == allColumns.size() + 1) {
+ return null;
+ }
+ Set<ColumnReference> includedColumns =
Sets.newLinkedHashSetWithExpectedSize(row.size());
+ long ts = 0;
+ for (Cell cell : row) {
+ includedColumns.add(new
ColumnReference(CellUtil.cloneFamily(cell), CellUtil.cloneQualifier(cell)));
+ if (ts < cell.getTimestamp()) {
+ ts = cell.getTimestamp();
+ }
+ }
Review comment:
Lines from 1163 to 1169 seem to be a good candidate to have in a separate
function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
