[
https://issues.apache.org/jira/browse/PHOENIX-5117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961799#comment-16961799
]
Hadoop QA commented on PHOENIX-5117:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12984236/PHOENIX-5117-4.x-HBase-1.4-v6.patch
against 4.x-HBase-1.4 branch at commit
6ce24abf310ff1d0fb8976a02be5758a6d311ab2.
ATTACHMENT ID: 12984236
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public QueryCompiler(PhoenixStatement statement, SelectStatement
select, ColumnResolver resolver, List<? extends PDatum> targetColumns,
ParallelIteratorFactory parallelIteratorFactory, SequenceManager
sequenceManager, boolean projectTuples, boolean optimizeSubquery, Map<TableRef,
QueryPlan> dataPlans, StatementContext parentContext) throws SQLException {
+ protected QueryPlan compileSubquery(SelectStatement subquery, boolean
pushDownMaxRows, StatementContext parentContext) throws SQLException {
+ getWrappedScanner(c, innerScanner, offset, scan,
dataColumns, tupleProjector,
+ public boolean next(List<Cell> results, ScannerContext
scannerContext) throws IOException {
+ throw new IOException("Next with scannerContext should not be called
in Phoenix environment");
+ * 3) In case of region close by balancer/move wait before closing the
reason and fail the query which
+ field.getMaxLength(),
field.getScale(), field.getSortOrder(),
+ firstKV.getRowArray(), firstKV.getRowOffset()
+ offset, firstKV.getRowLength(),
+ firstException = new SQLException("Encountered exception
in sub plan [" + i + "] execution.",
+ public RegionScannerResultIterator(Scan scan, RegionScanner scanner,
Pair<Integer, Integer> minMaxQualifiers, QualifierEncodingScheme
encodingScheme) {
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3077//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3077//console
This message is automatically generated.
> Return the count of rows scanned in HBase
> -----------------------------------------
>
> Key: PHOENIX-5117
> URL: https://issues.apache.org/jira/browse/PHOENIX-5117
> Project: Phoenix
> Issue Type: New Feature
> Affects Versions: 4.14.1
> Reporter: Chen Feng
> Assignee: Chen Feng
> Priority: Minor
> Fix For: 4.15.1, 5.1.1
>
> Attachments: PHOENIX-5117-4.x-HBase-1.4-v1.patch,
> PHOENIX-5117-4.x-HBase-1.4-v2.patch, PHOENIX-5117-4.x-HBase-1.4-v3.patch,
> PHOENIX-5117-4.x-HBase-1.4-v4.patch, PHOENIX-5117-4.x-HBase-1.4-v5.patch,
> PHOENIX-5117-4.x-HBase-1.4-v6.patch, PHOENIX-5117-v1.patch
>
>
> HBASE-5980 provides the ability to return the number of rows scanned. Such
> metrics should also be returned by Phoenix.
> HBASE-21815 is acquired.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
