BinShi-SecularBird commented on a change in pull request #614: PHOENIX-5553:
Transactional views should not get GlobalIndexChecker c…
URL: https://github.com/apache/phoenix/pull/614#discussion_r340423696
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -927,7 +928,16 @@ private void addCoprocessors(byte[] tableName,
TableDescriptorBuilder builder, P
boolean isViewIndex = TRUE_BYTES_AS_STRING
.equals(tableProps.get(MetaDataUtil.IS_VIEW_INDEX_TABLE_PROP_NAME));
- if ((tableType == PTableType.INDEX && !isTransactional) ||
isViewIndex) {
+ boolean isViewBaseTransactional = false;
+ if (!isTransactional && isViewIndex) {
+ if (tableProps.containsKey(TRANSACTIONAL) &&
+ Boolean.TRUE.equals(tableProps.get(TRANSACTIONAL))) {
+ isViewBaseTransactional = true;
Review comment:
The whole logic is a mess which should be cleaned. I don't understand why we
need to check "Boolean.TRUE.equals(tableProps.getOrDefault(TRANSACTIONAL,
FALSE))" particularly for viewIndex? Shouldn't "isTransactional = (provider !=
null) && Boolean.TRUE.equals(tableProps.getOrDefault(TRANSACTIONAL, FALSE))" be
applied to both INDEX and viewIndex, and simplify "if (!isTransactional &&
!isViewBaseTransactional && (tableType == PTableType.INDEX || isViewIndex))" as
(!isTransactional && (tableType == PTableType.INDEX || isViewIndex))?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
